Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OTLP Exporter doc - provide recommendation on custom AuthN #5380

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

reyang
Copy link
Member

@reyang reyang commented Feb 22, 2024

  1. Switched to GFM style NOTE.
  2. Provided recommendations on how to do custom authentication.

@reyang reyang requested a review from a team February 22, 2024 19:47
Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

reyang and others added 2 commits February 22, 2024 14:43
Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
@utpilla utpilla merged commit 88b6b0e into open-telemetry:main Feb 22, 2024
17 checks passed
@reyang reyang deleted the reyang/add-notes-about-auth branch March 2, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants