Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] ExperimentalAttribute decorations for experimental exemplar APIs #5153

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

CodeBlanch
Copy link
Member

Follow-up to #5151

Changes

  • Defines OTEL1002 in docs for experimental Exemplar APIs.
  • Adds .NET 8 ExperimentalAttribute decoration for experimental Exemplar APIs in SDK.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team December 9, 2023 05:51
Copy link

codecov bot commented Dec 9, 2023

Codecov Report

Merging #5153 (3d7c414) into main (cd000be) will decrease coverage by 0.18%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5153      +/-   ##
==========================================
- Coverage   83.27%   83.10%   -0.18%     
==========================================
  Files         297      297              
  Lines       12380    12379       -1     
==========================================
- Hits        10310    10288      -22     
- Misses       2070     2091      +21     
Flag Coverage Δ
unittests 83.10% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../Metrics/Builder/MeterProviderBuilderExtensions.cs 100.00% <ø> (ø)
...emetry/Metrics/Exemplar/AlwaysOffExemplarFilter.cs 0.00% <ø> (ø)
...lemetry/Metrics/Exemplar/AlwaysOnExemplarFilter.cs 100.00% <ø> (ø)
src/OpenTelemetry/Metrics/Exemplar/Exemplar.cs 100.00% <ø> (ø)
...metry/Metrics/Exemplar/TraceBasedExemplarFilter.cs 0.00% <ø> (ø)

... and 9 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 3846874 into open-telemetry:main Dec 11, 2023
77 checks passed
@CodeBlanch CodeBlanch deleted the sdk-exemplars-diagnostics branch December 11, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants