Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation comments for OpenTelemetryDependencyInjectionMeterProviderBuilderExtensions.ConfigureServices #5139

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Update documentation comments for OpenTelemetryDependencyInjectionMeterProviderBuilderExtensions.ConfigureServices #5139

merged 3 commits into from
Dec 7, 2023

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Dec 7, 2023

Changes

  • Update documentation comments for OpenTelemetryDependencyInjectionMeterProviderBuilderExtensions.ConfigureServices

@utpilla utpilla requested a review from a team December 7, 2023 02:18
@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

Merging #5139 (11b9904) into main (57ee852) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5139      +/-   ##
==========================================
+ Coverage   83.15%   83.18%   +0.02%     
==========================================
  Files         297      297              
  Lines       12369    12369              
==========================================
+ Hits        10286    10289       +3     
+ Misses       2083     2080       -3
Flag Coverage Δ
unittests 83.18% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pendencyInjectionMeterProviderBuilderExtensions.cs 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

CodeBlanch
CodeBlanch approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit ac56c9f into open-telemetry:main Dec 7, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@vishweshbankwar vishweshbankwar vishweshbankwar approved these changes

@CodeBlanch CodeBlanch CodeBlanch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@utpilla @cijothomas @vishweshbankwar @CodeBlanch