Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Moq dependency from Instrumentation.SqlClient.Tests #5125

Conversation

ngruson
Copy link
Contributor

@ngruson ngruson commented Dec 3, 2023

Related to #4758.

Changes

Refactored SqlEventSourceTests.cs
Removed Moq dependency

@ngruson ngruson requested a review from a team December 3, 2023 15:46
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Merging #5125 (13cac44) into main (55f76f6) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 13cac44 differs from pull request most recent head f5e1744. Consider uploading reports for the commit f5e1744 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5125      +/-   ##
==========================================
+ Coverage   83.03%   83.08%   +0.04%     
==========================================
  Files         296      296              
  Lines       12320    12320              
==========================================
+ Hits        10230    10236       +6     
+ Misses       2090     2084       -6     
Flag Coverage Δ
unittests 83.08% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

@utpilla utpilla merged commit a3d2fec into open-telemetry:main Dec 4, 2023
@ngruson ngruson deleted the remove-moq-instrumentation-sqlclient-tests branch December 6, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants