Removed Moq dependency from Exporter.OpenTelemetryProtocol.Tests #5118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5118 +/- ##
==========================================
+ Coverage 82.81% 83.05% +0.23%
==========================================
Files 296 296
Lines 12320 12320
==========================================
+ Hits 10203 10232 +29
+ Misses 2117 2088 -29
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
|
||
| namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.Mock; | ||
|
|
||
| internal class MockExportClient<T>(bool throwException = false) : IExportClient<T> |
vishweshbankwar
approved these changes
Dec 4, 2023
utpilla
reviewed
Dec 4, 2023
...er.OpenTelemetryProtocol.Tests/Implementation/ExportClient/OtlpHttpTraceExportClientTests.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Dec 4, 2023
test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/OtlpLogExporterTests.cs
Outdated
Show resolved
Hide resolved
|
Test failed due a Docker error 503 Service Unavailable in SqlClient.Tests. |
utpilla
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4758.
Refactor in order to remove the Moq dependency from the
OpenTelemetry.Exporter.OpenTelemetryProtocol.Testsproject.Changes
MockHttpMessageHandlerMockExportClientMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes