-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for instrumentation scope attributes (Meter tags) #5089
Merged
utpilla
merged 21 commits into
open-telemetry:main
from
cijothomas:cijothomas/metertags
Nov 29, 2023
Merged
Add support for instrumentation scope attributes (Meter tags) #5089
utpilla
merged 21 commits into
open-telemetry:main
from
cijothomas:cijothomas/metertags
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5089 +/- ##
==========================================
- Coverage 83.36% 83.27% -0.10%
==========================================
Files 296 296
Lines 12339 12355 +16
==========================================
+ Hits 10287 10289 +2
- Misses 2052 2066 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
utpilla
reviewed
Nov 28, 2023
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/MetricItemExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/MetricItemExtensions.cs
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/MetricItemExtensions.cs
Outdated
Show resolved
Hide resolved
CodeBlanch
reviewed
Nov 28, 2023
alanwest
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/MetricItemExtensions.cs
Show resolved
Hide resolved
alanwest
approved these changes
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
reviewed
Nov 28, 2023
utpilla
approved these changes
Nov 29, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4563
Did not touch Prometheus exporters in this PR, better to wait till #5086 is merged.
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes