Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove threshold for MetricPoint reclaim #5087

Merged

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Nov 28, 2023

Towards #2360

If a user opts-in for Metric Point reclaim feature, then the SDK would now just start the reclaiming behavior instead of waiting for the usage to reach a threshold. This is done to clean-up metrics faster. The threshold was originally introduced to avoid the perf impact for users who wouldn't require the reclaim feature. Now that MetricPoint reclaim is not enabled by default and is only enabled for users who opt-in for it, we could get rid of the threshold check.

Changes

  • Remove threshold for MetricPoint reclaim
  • Update MetricPoint reclaim tests to also run with the metric overflow attribute set to true

Merge requirement checklist

  • Appropriate CHANGELOG.md files updated for non-trivial changes

@utpilla utpilla requested a review from a team November 28, 2023 03:49
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #5087 (885ebcd) into main (eec09c9) will decrease coverage by 0.05%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5087      +/-   ##
==========================================
- Coverage   83.38%   83.33%   -0.05%     
==========================================
  Files         296      296              
  Lines       12348    12339       -9     
==========================================
- Hits        10296    10283      -13     
- Misses       2052     2056       +4     
Flag Coverage Δ
unittests 83.33% <87.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/AggregatorStore.cs 80.00% <87.50%> (-1.61%) ⬇️

... and 7 files with indirect coverage changes

@utpilla utpilla merged commit 324ab61 into open-telemetry:main Nov 28, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants