Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogRecord doesn't support any type for body #5724

Open
lmolkova opened this issue Jun 26, 2024 · 2 comments
Open

LogRecord doesn't support any type for body #5724

lmolkova opened this issue Jun 26, 2024 · 2 comments
Labels
bug Something isn't working logs Logging signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package spec-compliance Issues related to compliance with the OpenTelemetry Specification
Milestone
Future

Comments

@lmolkova
Copy link

lmolkova commented Jun 26, 2024 •
edited
Loading

The spec requires LogRecord to support any type:

https://github.com/open-telemetry/opentelemetry-specification/blob/9182f113aebac38f592d283977a1e7bce8281929/specification/logs/data-model.md?plain=1#L414

Body MUST support any type to preserve the semantics of
structured logs emitted by the applications.

However LogRecord in .NET allows to record string body only

opentelemetry-dotnet/src/OpenTelemetry/Logs/LogRecord.cs

Line 251 in 4d254eb

public string? Body

@lmolkova lmolkova changed the title LogRecord doesn't support any type LogRecord doesn't support any type for body Jun 27, 2024
@reyang reyang added logs Logging signal related bug Something isn't working labels Jun 28, 2024
@reyang reyang added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Jul 11, 2024
@shenyutong10086
Copy link

I am working on it..

@CodeBlanch CodeBlanch added this to the Future milestone Aug 16, 2024
@CodeBlanch CodeBlanch added the spec-compliance Issues related to compliance with the OpenTelemetry Specification label Aug 16, 2024
@CodeBlanch
Copy link
Member

@shenyutong10086 If you are interested in working on this please start with a proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working logs Logging signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package spec-compliance Issues related to compliance with the OpenTelemetry Specification
Projects
None yet
Milestone
Future
Development

No branches or pull requests
4 participants
@lmolkova @reyang @CodeBlanch @shenyutong10086