Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test stability - DiagnosticSourceExceptionCallBackIsNotReceivedForExceptionsHandledInMiddleware #4884

Closed
reyang opened this issue Sep 25, 2023 · 4 comments
Closed

Test stability - DiagnosticSourceExceptionCallBackIsNotReceivedForExceptionsHandledInMiddleware #4884

reyang opened this issue Sep 25, 2023 · 4 comments
Assignees
@vishweshbankwar
Labels
bug Something isn't working

Comments

@reyang
Copy link
Member

reyang commented Sep 25, 2023

@vishweshbankwar FYI

#4878 (comment)

image
@reyang reyang added the bug Something isn't working label Sep 25, 2023
@reyang
Copy link
Member Author

reyang commented Oct 12, 2023

Failed again https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/6499900758/job/17654193107?pr=4933

image

@vishweshbankwar
Copy link
Member

I looked at this briefly and it looks like another test is interfering with this one. I will send a PR to disable this one for now until I get chance to take a look more deeply.

@reyang
Copy link
Member Author

reyang commented Oct 13, 2023

Failed again https://github.com/open-telemetry/opentelemetry-dotnet/actions/runs/6504589733/job/17666762874?pr=4933.

image

@vishweshbankwar vishweshbankwar mentioned this issue Oct 13, 2023
Merged
@ngruson
Copy link
Contributor

ngruson commented Nov 22, 2023

In PR #5040, we refactored a couple of unit tests and decided to enable DiagnosticSourceExceptionCallBackIsNotReceivedForExceptionsHandledInMiddleware again.
This unit test is passing for each TFM now.
Can this issue be closed or leave it open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vishweshbankwar vishweshbankwar

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ngruson @reyang @vishweshbankwar