Improve BatchExportActivityProcessorTest.CheckShutdownExport stability (

#5567)
open-telemetry · Apr 24, 2024 · 51baf9f · 51baf9f
1 parent 98a5d3e
commit 51baf9f
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/test/OpenTelemetry.Tests/Trace/BatchExportActivityProcessorTest.cs b/test/OpenTelemetry.Tests/Trace/BatchExportActivityProcessorTest.cs
@@ -118,7 +118,7 @@ public void CheckForceFlushExport(int timeout)
     [InlineData(Timeout.Infinite)]
     [InlineData(0)]
     [InlineData(1)]
-    public void CheckShutdownExport(int timeout)
+    public void CheckShutdownExport(int timeoutMilliseconds)
     {
         var exportedItems = new List<Activity>();
         using var exporter = new InMemoryExporter<Activity>(exportedItems);
@@ -134,12 +134,11 @@ public void CheckShutdownExport(int timeout)
         };
 
         processor.OnEnd(activity);
-        processor.Shutdown(timeout);
+        processor.Shutdown(timeoutMilliseconds);
 
-        if (timeout == 0)
+        if (timeoutMilliseconds < 1_000)
         {
-            // Shutdown(0) will trigger flush and return immediately, so let's sleep for a while
-            Thread.Sleep(1_000);
+            Thread.Sleep(1_000 - timeoutMilliseconds);
         }
 
         Assert.Single(exportedItems);