Code review.

open-telemetry · Feb 21, 2024 · 19abd86 · 19abd86
1 parent 8fc0091
commit 19abd86
Showing 1 changed file with 2 additions and 14 deletions.
diff --git a/src/OpenTelemetry/Internal/InterlockedHelper.cs b/src/OpenTelemetry/Internal/InterlockedHelper.cs
@@ -15,13 +15,7 @@ public static void Add(ref double location, double value)
         // we'll end up in an Interlocked.CompareExchange loop anyway.
         double currentValue = Volatile.Read(ref location);
 
-        double updatedValue;
-        unchecked
-        {
-            updatedValue = currentValue + value;
-        }
-
-        var returnedValue = Interlocked.CompareExchange(ref location, updatedValue, currentValue);
+        var returnedValue = Interlocked.CompareExchange(ref location, currentValue + value, currentValue);
         if (returnedValue != currentValue)
         {
             AddRare(ref location, value, returnedValue);
@@ -40,13 +34,7 @@ private static void AddRare(ref double location, double value, double currentVal
         {
             sw.SpinOnce();
 
-            double updatedValue;
-            unchecked
-            {
-                updatedValue = currentValue + value;
-            }
-
-            var returnedValue = Interlocked.CompareExchange(ref location, updatedValue, currentValue);
+            var returnedValue = Interlocked.CompareExchange(ref location, currentValue + value, currentValue);
             if (returnedValue == currentValue)
             {
                 break;