ci: capture script failures properly #159
Conversation
WalkthroughThe pull request focuses on enhancing error handling across several development helper scripts in the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* ci: capture exit code properly * chore: simplify exit * style: fix whitespace
This reverts commit 4cdb71f.
alex-liang3
force-pushed
the
ci/fail-checks-properly
branch
from
4ac5190 to
3cf786b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
tools/development/helpers/check-format-cpp.sh(1 hunks)tools/development/helpers/check-format-python.sh(1 hunks)tools/development/helpers/format-cpp.sh(1 hunks)tools/development/helpers/format-python.sh(1 hunks)tools/development/helpers/test-python.sh(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.10.0)
tools/development/helpers/test-python.sh
[error] 10-10: Double quote array expansions to avoid re-splitting elements.
(SC2068)
tools/development/helpers/format-cpp.sh
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
tools/development/helpers/check-format-cpp.sh
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
🔇 Additional comments (5)
tools/development/helpers/format-python.sh (1)
9-10: LGTM! Proper error handling added.The addition of
|| exit 1ensures the script fails fast if the black formatter encounters any issues.tools/development/helpers/check-format-python.sh (1)
9-10: LGTM! Proper error handling added.The addition of
|| exit 1ensures the script fails fast if the black formatter check detects any formatting issues.tools/development/helpers/test-python.sh (1)
10-11: LGTM! Proper error handling added.The addition of
|| exit 1ensures the script fails fast if any tests fail.🧰 Tools
🪛 Shellcheck (0.10.0)
[error] 10-10: Double quote array expansions to avoid re-splitting elements.
(SC2068)
tools/development/helpers/format-cpp.sh (1)
9-10: LGTM! Proper error handling added.The addition of
|| exit 1ensures the script fails fast if clang-format encounters any issues.🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
tools/development/helpers/check-format-cpp.sh (1)
9-10: LGTM! Proper error handling added.The addition of
|| exit 1ensures the script fails fast if clang-format check detects any formatting issues.🧰 Tools
🪛 Shellcheck (0.10.0)
[warning] 9-9: Quote this to prevent word splitting.
(SC2046)
Merge this into
mainAFTER #158Duplicates #156, which was accidentally merged into the wrong base
Closes open-space-collective/open-space-toolkit-core#182
Summary by CodeRabbit