-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: install cmake from binary instead of source #154
Conversation
WalkthroughThe pull request introduces multi-platform build support by adding a Changes
Sequence DiagramsequenceDiagram
participant Build System
participant Makefile
participant Dockerfile
participant CMake Installer
Build System->>Makefile: Set TARGETPLATFORM
Makefile-->>Dockerfile: Pass TARGETPLATFORM
Dockerfile->>CMake Installer: Download platform-specific binary
CMake Installer-->>Dockerfile: Install CMake
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This MR changes the dockerfile to install cmake from a pre-built binary using the self install shell script (which was excruciatingly slow before) for the specifc platform. This should help get the build time way below the 6h GH actions limit.
I checked that this works locally and results in the
bin
andshare
and other directories that comes with cmake when it is built from source are all installed in the correct place under/usr/local
Here's an example of someone else doing pretty much the same install from pre-built binary (except they just install it in the /opt dir and symlink it whereas we directly install it in the correct place with the --prefix option)
Summary by CodeRabbit
New Features
Chores
Infrastructure
TARGETPLATFORM
variable to support cross-platform compatibility