Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: install cmake from binary instead of source #154

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

apaletta3
Copy link
Contributor

@apaletta3 apaletta3 commented Jan 15, 2025

This MR changes the dockerfile to install cmake from a pre-built binary using the self install shell script (which was excruciatingly slow before) for the specifc platform. This should help get the build time way below the 6h GH actions limit.

I checked that this works locally and results in the bin and share and other directories that comes with cmake when it is built from source are all installed in the correct place under /usr/local
Here's an example of someone else doing pretty much the same install from pre-built binary (except they just install it in the /opt dir and symlink it whereas we directly install it in the correct place with the --prefix option)

Summary by CodeRabbit

  • New Features

    • Added support for multi-platform builds across build configuration files
    • Enhanced Docker build process to handle different target platforms
  • Chores

    • Updated GitHub Actions workflow build configuration
    • Simplified CMake installation process in development Dockerfile
  • Infrastructure

    • Introduced TARGETPLATFORM variable to support cross-platform compatibility

@apaletta3 apaletta3 self-assigned this Jan 15, 2025
@apaletta3 apaletta3 requested review from alex-liang3 and vishwa2710 and removed request for alex-liang3 January 15, 2025 03:31
Copy link

coderabbitai bot commented Jan 15, 2025

Walkthrough

The pull request introduces multi-platform build support by adding a TARGETPLATFORM environment variable to the Makefile and Dockerfile. This change enables more flexible build configurations across different platforms, with a default setting of linux/amd64. The modifications primarily focus on enhancing the CMake installation process in the development Dockerfile, allowing for platform-specific binary downloads and simplifying the installation method.

Changes

File Change Summary
Makefile Added TARGETPLATFORM variable defaulting to linux/amd64
docker/development/Dockerfile Added ARG TARGETPLATFORM and modified CMake installation to use platform-specific binary download
.github/workflows/build-image.yml Removed cache-from option from the GitHub Actions workflow

Sequence Diagram

sequenceDiagram
    participant Build System
    participant Makefile
    participant Dockerfile
    participant CMake Installer

    Build System->>Makefile: Set TARGETPLATFORM
    Makefile-->>Dockerfile: Pass TARGETPLATFORM
    Dockerfile->>CMake Installer: Download platform-specific binary
    CMake Installer-->>Dockerfile: Install CMake
Loading

Possibly related PRs

Suggested reviewers

  • vishwa2710
  • alex-liang3
  • Derollez

Poem

🐰 Builds that hop across the land,
Platforms dancing, hand in hand
CMake leaps with agile grace
Multi-platform builds embrace!
Rabbit's build magic takes flight 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 23b4b9e and 5854574.

📒 Files selected for processing (1)
  • .github/workflows/build-image.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/build-image.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alex-liang3 alex-liang3 merged commit f24d567 into main Jan 15, 2025
4 checks passed
@alex-liang3 alex-liang3 deleted the build/install-cmake-from-binary branch January 15, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants