-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove base image multi-stage build #129
Conversation
2e2a329
to
e953526
Compare
Caution Review failedThe pull request is closed. WalkthroughThe pull request introduces changes to the GitHub Actions workflow for building base Docker images and the corresponding Dockerfile. The workflow has been streamlined by consolidating multiple build jobs into a single job, simplifying the image build and push process. The Dockerfile has been updated to reflect these changes, with base image stage names modified to align with the new workflow structure. Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
For reference, this MR is the one that sped up the python installation process. |
e953526
to
29b3d1b
Compare
Now that the build process is much shorter (because we are no longer building python from source), we can build the base image in one stage because it no longer exceeds the 6 hour CI build limit
Summary by CodeRabbit
Summary by CodeRabbit