Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove base image multi-stage build #129

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

apaletta3
Copy link
Contributor

@apaletta3 apaletta3 commented Jun 12, 2024

Now that the build process is much shorter (because we are no longer building python from source), we can build the base image in one stage because it no longer exceeds the 6 hour CI build limit

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Streamlined GitHub Actions workflow for base image build process.
    • Simplified Docker base image stage naming.
    • Consolidated build and push operations into a single job.

@apaletta3 apaletta3 marked this pull request as ready for review June 12, 2024 09:15
@apaletta3 apaletta3 requested review from vishwa2710 and Derollez June 12, 2024 09:19
@apaletta3 apaletta3 marked this pull request as draft June 12, 2024 14:46
@apaletta3 apaletta3 force-pushed the build/remove-base-image-multi-stage-build branch from 2e2a329 to e953526 Compare January 8, 2025 16:06
Copy link

coderabbitai bot commented Jan 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request introduces changes to the GitHub Actions workflow for building base Docker images and the corresponding Dockerfile. The workflow has been streamlined by consolidating multiple build jobs into a single job, simplifying the image build and push process. The Dockerfile has been updated to reflect these changes, with base image stage names modified to align with the new workflow structure.

Changes

File Change Summary
.github/workflows/build-base-image.yml - Renamed job from build-part1-of-base-image to build-and-push-and-tag-base-image
- Removed build-part2-and-push-and-tag-base-image job
- Updated push-and-tag-base-image-as-latest job dependencies
docker/development/Dockerfile - Renamed base image stage from base1 to base
- Updated subsequent stage from base1 to base2

Possibly related PRs

  • build: bump boost version #142: The changes in the Dockerfile regarding the renaming of base image stages in the main PR are related to the modifications in the Dockerfile in PR build: bump boost version #142, as both involve updates to the Dockerfile structure, although the specific changes differ in purpose.

Suggested reviewers

  • vishwa2710

Poem

🐰 A Rabbit's Ode to Workflow Delight
Streamlined builds, jobs now light,
Docker stages dancing bright,
One job to rule them, push with might,
Efficiency leaps to a new height!
🚀 Simplicity wins the coding fight! 🛠️


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e953526 and 29b3d1b.

📒 Files selected for processing (2)
  • .github/workflows/build-base-image.yml (1 hunks)
  • docker/development/Dockerfile (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@apaletta3 apaletta3 marked this pull request as ready for review January 8, 2025 16:08
@apaletta3 apaletta3 requested a review from alex-liang3 January 8, 2025 16:20
@alex-liang3
Copy link
Contributor

For reference, this MR is the one that sped up the python installation process.

@apaletta3 apaletta3 force-pushed the build/remove-base-image-multi-stage-build branch from e953526 to 29b3d1b Compare January 8, 2025 19:16
@apaletta3 apaletta3 enabled auto-merge (squash) January 8, 2025 19:16
@apaletta3 apaletta3 merged commit 722faed into main Jan 8, 2025
2 of 3 checks passed
@apaletta3 apaletta3 deleted the build/remove-base-image-multi-stage-build branch January 8, 2025 19:16
@coderabbitai coderabbitai bot mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants