build: prepare for test matrix #107
Conversation
WalkthroughThe pull request introduces a new Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (4)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
Makefile (2)
545-546: Fix typo and improve target documentation.The target description has a typo and could be more specific about its prerequisites.
-ci-test-python: ## Run Python unit tests. Assumes the dev image has already been built, AND that bindings have been built and are avaliable at `packages/python` +ci-test-python: ## Run Python unit tests. Assumes the dev image has already been built, and bindings have been built and are available at 'packages/python'
549-558: Consider adding error handling for missing prerequisites.The target assumes that the development image and Python bindings exist but doesn't verify these prerequisites. This could lead to confusing errors if they're missing.
Consider adding checks at the beginning of the target:
ci-test-python: + @ if [ ! -d "packages/python" ]; then \ + echo "Error: Python bindings not found in packages/python. Run 'make build-packages-python' first." >&2; \ + exit 1; \ + fi + @ echo "Running Python unit tests..."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build-test.yml(1 hunks)Makefile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Build Development Image / Build Development Image
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
=======================================
Coverage 69.47% 69.47%
=======================================
Files 7 7
Lines 498 498
=======================================
Hits 346 346
Misses 152 152 ☔ View full report in Codecov by Sentry. |
vishwa2710
force-pushed
the
build/prep-test-matrix
branch
from
a0b0619 to
33512b9
Compare
Adds a new Makefile directive to be used in CI to facilitate unit testing multiple Python versions. This should be merged BEFORE open-space-collective/open-space-toolkit#144, and will only kick in after the latter is merged.
Summary by CodeRabbit