Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust scanner fusion question #184

Open
Goghzki opened this issue May 14, 2021 · 2 comments
Open

robust scanner fusion question #184

Goghzki opened this issue May 14, 2021 · 2 comments
Assignees
Labels
question Further information is requested

Comments

@Goghzki
Copy link

Goghzki commented May 14, 2021

hi~, I think the robust_scanner_fusion_layer.py is not the original method in is's parper https://arxiv.org/pdf/2007.07542.pdf
In git:
output = self.linear_layer(fusion_input)
output = self.glu_layer(output)
In parper :
->
output1 = self.linear_layer(fusion_input)
output1 = torch.sigmoid(output1)
output2 = self.linear_layer(fusion_input)
output = torch.mul(output1 , output2 )

Actually In my sentence level dataset, I found many alignment drift case, which should be fixed by robust_scanner_fusion_layer.
I don't know is this right?

@Goghzki Goghzki closed this as completed May 14, 2021
@Goghzki Goghzki reopened this May 14, 2021
@innerlee innerlee added the question Further information is requested label May 14, 2021
@innerlee
Copy link
Contributor

innerlee commented May 14, 2021

@cuhk-hbsun Pytorch has an implementation of glu, maybe we can use it.

@Goghzki
Copy link
Author

Goghzki commented May 14, 2021

image
mabey it is different?
torch split the input in to two parts a and b, and use sigmoid function only to b(not both) , then mul a and sigmoid b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants