teams: smoother resource remove (fixes #4916) #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppp15
changed the title
Kuljeet1998
approved these changes
Dec 26, 2024
Avinash-Codes
approved these changes
Dec 26, 2024
|
@deeppp15 how does this work? was'nt able to figure it out |
Okuro3499
requested changes
Jan 5, 2025
| @@ -25,25 +30,48 @@ class AdapterTeamResource(private val context: Context, private val list: List<R | |||
| } | |||
|
|
|||
| override fun onCreateViewHolder(parent: ViewGroup, viewType: Int): ViewHolderTeamResource { | |||
| rowTeamResourceBinding = RowTeamResourceBinding.inflate(LayoutInflater.from(context), parent, false) | |||
| return ViewHolderTeamResource(rowTeamResourceBinding) | |||
| val binding = RowTeamResourceBinding.inflate(LayoutInflater.from(context), parent, false) | |||
There was a problem hiding this comment.
why is these being renamed?
There was a problem hiding this comment.
Hi @Okuro3499 , reverted variable names
Comment on lines
40
to
47
| holder.binding.tvTitle.text = resource.title | ||
| holder.binding.tvDescription.text = resource.description | ||
|
|
||
| holder.itemView.setOnClickListener { | ||
| listener?.openLibraryDetailFragment(list[position]) | ||
| listener?.openLibraryDetailFragment(resource) | ||
| } | ||
| rowTeamResourceBinding.ivRemove.setOnClickListener { } | ||
| if (!settings.getString("userId", "--").equals(teamCreator, ignoreCase = true)) { | ||
| rowTeamResourceBinding.ivRemove.visibility = View.GONE | ||
|
|
||
| holder.binding.ivRemove.setOnClickListener { |
There was a problem hiding this comment.
these ones too from rowTeamResourceBinding to holder.binding.
There was a problem hiding this comment.
Hi @Okuro3499 , reverted variable names
…planet into 4916-teams-resource-removal
|
how does this work? I am a team leader of a team and I can't remove resources even for the teams I am not a team leader |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshots
When user is team leader
leader adding removing resources.webm
When user is not team leader
