Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: less strings is more (fixes #4898) #4899

Merged
merged 4 commits into from
Dec 23, 2024
Merged

all: less strings is more (fixes #4898) #4899

merged 4 commits into from
Dec 23, 2024

Conversation

deeppp15
Copy link
Member

dogi
dogi requested changes Dec 19, 2024
View reviewed changes
Copy link
Member

@dogi dogi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeppp15 there is 4 more strings to remove

Okuro3499
Okuro3499 requested changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@Okuro3499 Okuro3499 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have multiple string files select is still available in the others

Avinash-Codes
Avinash-Codes requested changes Dec 20, 2024
View reviewed changes
Copy link
Member

@Avinash-Codes Avinash-Codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the same in all files(there are different stirngs.xml for different language)

@dogi dogi changed the title values: removed redundant string (fixes #4898) all: less strings is more (fixes #4898) Dec 23, 2024
@dogi dogi merged commit 73079f2 into master Dec 23, 2024
2 checks passed
@Okuro3499 Okuro3499 deleted the 4898-redundant-strings branch January 6, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avinash-Codes Avinash-Codes Avinash-Codes approved these changes

@Okuro3499 Okuro3499 Okuro3499 approved these changes

@dogi dogi dogi approved these changes

Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

string files not consistent
4 participants
@deeppp15 @dogi @Okuro3499 @Avinash-Codes