Save screenshots to a openGOAL folder in the users Pictures directory

[Zedb0T]

rn, Idk where they save on launcher version but I would assume the active directory, and maybe they get deleted on update? idk.

[ManDude]

They get saved to %appdata% like the savefiles.

[xTVaser]

I don't think that's correct, I think Zed is more correct.

• jak-project/common/util/FileUtil.cpp

  Line 692 in 349919f

  std::string make_screenshot_filepath(const GameVersion game_version, const std::string& name) {

• uses file_util::get_file_path which uses the project path as a base dir

  jak-project/common/util/FileUtil.cpp

  Lines 198 to 213 in 349919f

  	std::string get_file_path(const std::vector<std::string>& input) {
  	// TODO - clean this behaviour up, it causes unexpected behaviour when working with files
  	// the project path should be explicitly provided by whatever if needed
  	// TEMP HACK
  	// - if the provided path is absolute, don't add the project path
  	if (input.size() == 1 && fs::path(input.at(0)).is_absolute()) {
  	return input.at(0);
  	}
  	auto current_path = file_util::get_jak_project_dir();
  	for (auto& str : input) {
  	current_path /= str;
  	}
  	return current_path.string();
  	}

No reference to AppData, and locally testing it this appears to be the case.

If a change is made to this, the directory should imo be configurable as well (could use tinyfd_selectFolderDialog). (Also looks like the imgui settings file should also be moved to somewhere more centralized)

[ManDude]

You're right, I thought I had made the change a while back. If they're being deleted when the launcher updates the game, then that's pretty bad.