build(meta-provider): Support non-breaking versions of openfeature-sdk #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The meta provider's gemspec stated only v0.3.x could be used. Unfortunately, this conflicts with the official LaunchDarkly provider, which uses version 0.4.0, preventing this gem from being used along with it. This update allows either 0.3.0 or 0.4.0 to be used. Although technically speaking openfeature-sdk 0.3.0 -> 0.4.0 is a breaking change because of the change of string values. However, the provider uses only the constants rather than the string values so this should not break the provider. Signed-off-by: Jordan Blacker <jblacker@justworks.com>
jblacker
changed the title
Signed-off-by: Jordan Blacker <jblacker@justworks.com>
jblacker
force-pushed
the
update-required-openfeature-sdk
branch
from
62b9ecc to
db9f770
Compare
|
This is blocking work for us too, this unofficial Flagsmith provider depends on @thomaspoignant @beeme1mr tagging for visibility |
beeme1mr
approved these changes
Feb 28, 2025
beeme1mr
pushed a commit
that referenced
this pull request
Feb 28, 2025
🤖 I have created a release *beep* *boop* --- ## [0.0.4](openfeature-meta_provider/v0.0.3...openfeature-meta_provider/v0.0.4) (2025-02-28) ### 🛠️ Build * **meta-provider:** Support non-breaking versions of openfeature-sdk ([#47](#47)) ([5a98cf4](5a98cf4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
The meta provider's gemspec stated only v0.3.x could be used. Unfortunately, this conflicts with the official LaunchDarkly provider, which uses version 0.4.0, preventing this gem from being used along with it.
Although technically speaking openfeature-sdk 0.3.0 -> 0.4.0 is a breaking change because of the change of string values, but it should not cause a problem. This is because the provider uses only the constants rather than the string values themselves, so this should not break the provider.
Notes
I put <= 0.4 as the maximum version of the SDK, but this can be changed if ya'll think it should be a different value.
How to test
Import this branch into an application along with the the gem built from https://github.com/launchdarkly/openfeature-ruby-server and verify that using it within a meta-provider works correctly.