Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(redwood): send XBlock visibility status to the LMS #35

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(redwood): send XBlock visibility status to the LMS #35

merged 1 commit into from
Sep 30, 2024

Conversation

Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Sep 25, 2024 •
edited
Loading

Please see open-craft/edx-platform#688

Private-ref: BB-8826

@Agrendalath Agrendalath self-assigned this Sep 25, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (opencraft-release/redwood.1@a22759a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...re/course/sequence/Unit/hooks/useIFrameBehavior.js 94.11% 1 Missing ⚠️
Additional details and impacted files 
@@                      Coverage Diff                       @@
##             opencraft-release/redwood.1      #35   +/-   ##
==============================================================
  Coverage                               ?   88.82%           
==============================================================
  Files                                  ?      306           
  Lines                                  ?     5280           
  Branches                               ?     1311           
==============================================================
  Hits                                   ?     4690           
  Misses                                 ?      574           
  Partials                               ?       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Agrendalath Agrendalath force-pushed the agrendalath/bb-8826-completion-in-the-learning-mfe-redwood branch from 5b4d655 to 7dc01bb Compare September 25, 2024 17:52
@Agrendalath Agrendalath mentioned this pull request Sep 25, 2024
Merged
@Agrendalath Agrendalath marked this pull request as ready for review September 25, 2024 18:04
@Agrendalath Agrendalath changed the title fix: send XBlock visibility status to the LMS fix(redwood): send XBlock visibility status to the LMS Sep 25, 2024
farhaanbukhsh
farhaanbukhsh approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on tutor
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@Agrendalath Agrendalath merged commit 1774b3f into opencraft-release/redwood.1 Sep 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhaanbukhsh farhaanbukhsh farhaanbukhsh approved these changes

Assignees

@Agrendalath Agrendalath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Agrendalath @farhaanbukhsh