Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(palm): handle missing name in readonly enterprise account fields #672

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix(palm): handle missing name in readonly enterprise account fields #672

merged 1 commit into from
Sep 30, 2024

Conversation

Agrendalath
Copy link
Member

@Agrendalath Agrendalath commented Aug 19, 2024 •
edited
Loading

See the upstream PR: openedx#35541

Private-ref: BB-8954

@Agrendalath
fix: handle missing name in readonly enterprise account fields
c4849f5 
The `settings.ENTERPRISE_READONLY_ACCOUNT_FIELDS` list can be overridden.
Removing the `name` from it should not raise the `ValueError` exception.
@Agrendalath Agrendalath self-assigned this Aug 19, 2024
@Agrendalath Agrendalath changed the title fix: handle missing name in readonly enterprise account fields fix(palm): handle missing name in readonly enterprise account fields Sep 25, 2024
farhaanbukhsh
farhaanbukhsh approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@farhaanbukhsh farhaanbukhsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this.
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@Agrendalath Agrendalath merged commit 0cd6af4 into opencraft-release/palm.1 Sep 30, 2024
41 checks passed
@Agrendalath Agrendalath deleted the agrendalath/bb-8954-handle-missing-name-in-readonly-enterprise-fields branch September 30, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhaanbukhsh farhaanbukhsh farhaanbukhsh approved these changes

Assignees

@Agrendalath Agrendalath

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Agrendalath @farhaanbukhsh