From b8af2582b6bc1a2ddebdccc9f2a5d1c1ee33a49a Mon Sep 17 00:00:00 2001 From: 0x29a Date: Sat, 28 Sep 2024 11:26:37 +0200 Subject: [PATCH] fix: don't override discussion_enabled and enable_graded_units --- openedx/core/djangoapps/discussions/tasks.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/openedx/core/djangoapps/discussions/tasks.py b/openedx/core/djangoapps/discussions/tasks.py index fea20dc59bd4..3b598b34bddb 100644 --- a/openedx/core/djangoapps/discussions/tasks.py +++ b/openedx/core/djangoapps/discussions/tasks.py @@ -226,6 +226,8 @@ def update_unit_discussion_state_from_discussion_blocks(course_key: CourseKey, u if vertical.location in discussable_units: vertical.discussion_enabled = True subsections_with_discussions.add(vertical.parent) + elif getattr(vertical, 'discussion_enabled', False): + subsections_with_discussions.add(vertical.parent) else: vertical.discussion_enabled = False store.update_item(vertical, user_id) @@ -256,7 +258,10 @@ def update_unit_discussion_state_from_discussion_blocks(course_key: CourseKey, u discussion_config.unit_level_visibility = True discussion_config.save() # added delay of 30 minutes to allow for the course to be published - update_discussions_settings_from_course_task.apply_async( - args=[str(course_key), [str(unit) for unit in discussable_units]], - countdown=1800, + update_discussions_settings_from_course_task.apply( + args=[ + str(course_key), + [str(unit) for unit in discussable_units], + [str(vertical.location) for vertical in verticals if vertical.discussion_enabled] + ], )