-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jensen & Nugent 2017 example updates (incl. new smoke tests, Fig 7, 8 and Tab 4 notebooks); GrabowskiEtAl2011 diffusion thermics coefficient fix; Bolton1980 & Wexler1976 svp formulae; #1283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slayoo
requested changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bhiogade, please find below several comments
HTH
slayoo
reviewed
Feb 23, 2024
… & 6; modify test case of figure 4
… & 6; modify test case of figure 4
…_default and fake_unit_registry; modified bolton_1980.py
…to date) + cleanups (open-atmos#1296)
… 1938) + Reynolds number attr + air dynamic viscosity formulae + unit tests (incl. drop size changes upon ventilation-in-parcel-below-cloud vs. no-ventilation) + refactor of env vars __getitem__ logic (open-atmos#1282) Co-authored-by: Sylwester Arabas <sylwester.arabas@agh.edu.pl>
…dd `Formulae::get_constant()`) closes open-atmos#1243 (open-atmos#1269)
slayoo
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.