chore: rename DepositTxEnvelope to OpTransaction #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested review from
mattsse,
emhane,
refcell and
clabby
as code owners
refcell
approved these changes
Jan 21, 2025
emhane
requested changes
Jan 21, 2025
There was a problem hiding this comment.
I don't see a need to generalise the name of this trait, as far now, OP only has one additional transaction type. DepositTxEnvelope rather have super trait TransactionEnvelope trait declared in alloy-rs/alloy#1910 . If the trait be renamed, it makes more sense to rename it to OpTxEnvelope.
Comment on lines
+25
to
+26
| DepositTransaction, L1InfoDepositSource, TxDeposit, UpgradeDepositSource, UserDepositSource, | ||
| DEPOSIT_TX_TYPE_ID, |
There was a problem hiding this comment.
Suggested change
| DepositTransaction, L1InfoDepositSource, TxDeposit, UpgradeDepositSource, UserDepositSource, | |
| DEPOSIT_TX_TYPE_ID, | |
| DepositTransaction, L1InfoDepositSource, TxDeposit, UpgradeDepositSource, UserDepositSource, | |
| DEPOSIT_TX_TYPE_ID, OpTransaction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just changes the name / location of what is currently
DepositTxEnvelope, and changing docs to mention that this abstracts over any type of OP transaction, which is why theis_depositfn may return false, or theas_depositfn may return None, etc.