Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Declare OpTransactionEnvelope #120

Closed
emhane opened this issue Jan 21, 2025 · 3 comments
Closed

[Feature] Declare OpTransactionEnvelope #120

emhane opened this issue Jan 21, 2025 · 3 comments
Labels
C-blocked Category: cannot move forward until something else changes D-good-first-issue Desc: issues that are easy to pick up for new contributors

Comments

@emhane
Copy link
Member

emhane commented Jan 21, 2025 •
edited
Loading

Component

consensus

Describe the feature you would like

Declare trait OpTransactionEnvelope taking super traits TransactionEnvelope and DepositTxEnvelope as super traits. Add blanket implementation for all types that impl the super traits.

Additional context

No response
@emhane emhane added A-consensus D-good-first-issue Desc: issues that are easy to pick up for new contributors labels Jan 21, 2025
@emhane emhane mentioned this issue Jan 21, 2025
Closed
@emhane emhane added the C-blocked Category: cannot move forward until something else changes label Jan 21, 2025
@emhane
Copy link
Member Author

emhane commented Jan 21, 2025

blocked by alloy-rs/alloy#1910

@refcell
Copy link
Contributor

refcell commented Jan 23, 2025 •
edited
Loading

Shall we close this for now?

-- edit --

oops hit close

@refcell refcell closed this as completed Jan 23, 2025
@refcell refcell reopened this Jan 23, 2025
@emhane
Copy link
Member Author

emhane commented Jan 23, 2025

closing, ref alloy-rs/op-alloy#398

@emhane emhane closed this as completed Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-blocked Category: cannot move forward until something else changes D-good-first-issue Desc: issues that are easy to pick up for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@refcell @emhane