Miscellaneous indexing fixes #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
bookstack_fix
branch
from
2761003 to
79c1164
Compare
pablonyx
changed the base branch from
add_web_validation
to
connector_validation
rkuo-danswer
approved these changes
Feb 19, 2025
|
|
||
| return urls | ||
| except requests.RequestException as e: | ||
| raise RuntimeError(f"Failed to fetch sitemap from {sitemap_url}: {str(e)}") |
There was a problem hiding this comment.
f-string and {str(e)} is redundant
pablonyx
force-pushed
the
connector_validation
branch
from
907a0d3 to
8ea54e1
Compare
pablonyx
force-pushed
the
bookstack_fix
branch
from
a40f455 to
1758dfe
Compare
pablonyx
force-pushed
the
bookstack_fix
branch
from
cae8187 to
6fb85d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Provide a brief description of the changes in this PR]
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.