Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Agent Slowness #3979

Merged
merged 5 commits into from
Feb 13, 2025
Merged

Fix Agent Slowness #3979

merged 5 commits into from
Feb 13, 2025

Conversation

yuhongsun96
Copy link
Contributor

Description

All parallel queries go through the intent model which is not needed. Only the initial user query should go through that one.

For Evan:

  • Address all the TODOs
  • Make sure the other flows do not use intent model
  • Double check all Tools still work correctly
  • Try to make the design maintainable (no string checks)

How Has This Been Tested?

[Describe the tests you ran to verify your changes]

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)
  • [Optional] Override Linear Check

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2025 0:05am

@@ -57,10 +57,12 @@ def rerank_documents(
persona=graph_config.inputs.search_request.persona,
rerank_settings=graph_config.inputs.search_request.rerank_settings,
)
# TODO clean up implementation here
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to address this one

@yuhongsun96 yuhongsun96 merged commit 1a7aca0 into main Feb 13, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants