Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resolves] Support ingesting a digest model report/cache #3

Merged
merged 15 commits into from
Jan 24, 2025
Merged

[Resolves] Support ingesting a digest model report/cache #3

merged 15 commits into from
Jan 24, 2025

Conversation

pcolange
Copy link
Collaborator

@pcolange pcolange commented Dec 6, 2024

Closes #2

Initial commit for feature request #2.
e33c35c 
- Offers solution for steps 1-3
@pcolange pcolange self-assigned this Dec 6, 2024
Philip Colangelo added 8 commits December 9, 2024 16:48
Refined support for step3 -s
27f727a 
- added steps 4-6
update to pylintrc
3565e5a
more linting
76102d0
No longer test text file in favor of yaml
112403b
Code to validate report file
c86564f 
- robust pixmap handling
- better pixmap quality
- copy png instead of grab()
- scale loading gif
- multimodel report support
- recompiled gui with pyside6.8.1
[fix] analysis script
426d24f
[fix] test report skip key
db35c40
fixed critical threading issue with matplotlib
496ef19 
- various quality updates to gui
@pcolange pcolange added the enhancement New feature or request label Dec 12, 2024
@pcolange pcolange marked this pull request as ready for review December 12, 2024 23:35
@pcolange
Copy link
Collaborator Author

pcolange commented Dec 12, 2024 •
edited
Loading

TODO: add a check for duplicate YAML reports in the multi model analysis tool. Done in commit 03af35c

@pcolange pcolange mentioned this pull request Dec 18, 2024
Draft
danielholanda
danielholanda approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@danielholanda danielholanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested locally.
Worked like a charm.

test/test_reports.py Show resolved Hide resolved
test/resnet18_reports/resnet18_report.txt Outdated Show resolved Hide resolved
.pylintrc Show resolved Hide resolved
src/digest/gui_config.yaml Outdated Show resolved Hide resolved
src/digest/model_class/digest_report_model.py Outdated Show resolved Hide resolved
src/digest/model_class/digest_report_model.py Outdated Show resolved Hide resolved
src/digest/model_class/digest_report_model.py Outdated Show resolved Hide resolved
src/digest/multi_model_analysis.py Show resolved Hide resolved
@pcolange pcolange mentioned this pull request Jan 23, 2025
Closed
@pcolange
Merge branch 'main' into ingest-cache
e26e37a 
Signed-off-by: Philip <philipjcolangelo@gmail.com>
@pcolange pcolange merged commit cc55d21 into main Jan 24, 2025
7 checks passed
@pcolange pcolange deleted the ingest-cache branch January 31, 2025 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielholanda danielholanda danielholanda approved these changes

@ramkrishna2910 ramkrishna2910 Awaiting requested review from ramkrishna2910

Assignees

@pcolange pcolange

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ingesting a digest model report/cache
2 participants
@pcolange @danielholanda