Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translations #35

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add translations #35

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2015

No description provided.

Laurynas Gavienas added 2 commits April 3, 2015 14:21
- Fixed Javascript
390d2d6 
- Updated readme
- Added configuration parameters for multilingual content
- Added backend functionality for multilingual content saving and retrieval from DB
- Updated template logic to display multiple input fields for "title"…
3f1fda3 
… in modal window (for multilingual content)
@Zylius Zylius added the qa label Apr 7, 2015
@saimaz
Copy link
Contributor

saimaz commented Apr 8, 2015

@lauriis2 Can you describe in short what you did? And if there is still something missing?

@ghost
Copy link
Author

ghost commented Apr 8, 2015

What I did:

  • fixed some JavaScript bugs for front-end to start working
  • used StofDoctrineExtensionsBundle() for translations
  • modified Category entity to enable translations on title property
  • updated config structure for ongr_category_manager to enable adding locales and default_locale
  • updated some Angular logic to enable multiple title fields in modal window (for record editing)

What's left to do:

  • Probably think about updating inline record editing to enable multiple fields (or leave it as it is - it will update default locale's translation)
  • Maybe improve Angular code (I'm not front-ender)

@saimaz saimaz removed the qa label Apr 29, 2015
@saimaz
Copy link
Contributor

saimaz commented Apr 29, 2015

Ok, in review queue right now. Please do not merge this accidentally ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saimaz @Zylius