Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Executino] Chunk data pack pruning config fix #7112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhangchiqing
Copy link
Member

@zhangchiqing zhangchiqing commented Mar 3, 2025

This PR fixes two issues:

  1. When I increase the threshold to retain more chunk data packs, it run into a fatal error, saying the latest is less than next block.
{"level":"fatal",..."error":"failed to create block iterator: failed to create range for block iteration: latest block is less than next block: 242742568 < 245752965","time":"2025-03-03T20:40:39.583143782Z","message":"unhandled irrecoverable error"}

This is resolved by allowing the latest to go backward and even blow the next block to iterate.

  1. Report the pruning related metrics on startup, so that the metrics won't report as 0, which causes the dashboard showing some confusing spikes.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.22%. Comparing base (3561e2b) to head (d9f9397).

Files with missing lines Patch % Lines
module/block_iterator/state.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7112      +/-   ##
==========================================
- Coverage   41.22%   41.22%   -0.01%     
==========================================
  Files        2153     2153              
  Lines      189278   189278              
==========================================
- Hits        78029    78024       -5     
  Misses     104745   104745              
- Partials     6504     6509       +5     
Flag Coverage Δ
unittests 41.22% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhangchiqing zhangchiqing marked this pull request as ready for review March 3, 2025 21:37
@zhangchiqing zhangchiqing requested a review from a team as a code owner March 3, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants