Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Refactor grpc server setup for clarity #7094

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

peterargue
Copy link
Contributor

The grpc server interceptors were defined in different places and lacked explanation. move them all to grpcserver module and improve comments

@peterargue peterargue requested a review from a team as a code owner February 25, 2025 20:39
@peterargue peterargue changed the title Peter/refactor grpcserver [Access] Refactor grpc server setup for clarity Feb 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 22.97297% with 57 lines in your changes missing coverage. Please review.

Project coverage is 41.23%. Comparing base (3561e2b) to head (dd0d31b).

Files with missing lines Patch % Lines
module/grpcserver/server_builder.go 0.00% 13 Missing ⚠️
module/grpcserver/interceptor_logging.go 0.00% 10 Missing ⚠️
module/grpcserver/interceptor_context.go 0.00% 9 Missing ⚠️
module/grpcserver/server.go 0.00% 7 Missing ⚠️
engine/access/rpc/engine_builder.go 66.66% 6 Missing ⚠️
module/grpcserver/interceptor_ratelimit.go 0.00% 6 Missing ⚠️
engine/access/state_stream/backend/engine.go 0.00% 3 Missing ⚠️
engine/access/rpc/http_server.go 75.00% 0 Missing and 1 partial ⚠️
engine/collection/rpc/engine.go 0.00% 1 Missing ⚠️
engine/execution/rpc/engine.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7094      +/-   ##
==========================================
+ Coverage   41.22%   41.23%   +0.01%     
==========================================
  Files        2153     2154       +1     
  Lines      189278   189265      -13     
==========================================
+ Hits        78029    78049      +20     
+ Misses     104745   104712      -33     
  Partials     6504     6504              
Flag Coverage Δ
unittests 41.23% <22.97%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterargue peterargue enabled auto-merge March 3, 2025 17:43
@peterargue peterargue disabled auto-merge March 3, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants