Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add entities pool_pump.next_run_start and pool_pump.next_run_stop with format #15

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

dadge
Copy link

@dadge dadge commented Apr 24, 2021

Hello,
I added the entities pool_pump.next_run_start and pool_pump.next_run_stop
based on the comment of @mycanaletto in this issue : #9
Not 100% sure what kind of object state can store (datetime, string ? advice is welcome )

Regards,

@mycanaletto
Copy link

mycanaletto commented Apr 24, 2021

Hello !

I couldn't test it because since I reinstalled HACS it doesn't start anymore, as if something was missing in the configuration...

pool_pump:
  switch_entity_id: switch.sonoff_100032ac98_4
  pool_pump_mode_entity_id: input_select.pool_pump_mode
  pool_temperature_entity_id: sensor.sonoff_10002c7855_temperature


Invalid config for [pool_pump]: [pool_temperature_entity_id] is an invalid option for [pool_pump]. Check: pool_pump->pool_pump->pool_temperature_entity_id. (See /config/configuration.yaml, line 99).

@dadge
Copy link
Author

dadge commented Apr 24, 2021

My code is not merged yet... But I think for this error you have to take the correct version, the one in dev, 0.0.2beta1

@mycanaletto
Copy link

OK it works with the beta, I'm waiting for the merge for the new features. I'm especially interested in a winter mode...

@dadge
Copy link
Author

dadge commented Apr 24, 2021

Ok, could you descibe what you expect from a winter mode?
If you apply a passive wintering, you can set the mode to off, if you apply an active wintering, just keep the component in auto.
If I look the abacus provided by @oncleben31 it will always run 2h per day

https://www.github.com/scadinot/pool/tree/master/docs%2Fimages%2Ffiltration_courbe.png

By the way I read your article about how to migrate from jeedom to home assistant when I migrate to ha, I used it a lot, especially the climate part, nice job👍

@mycanaletto
Copy link

In fact, I take care of my brother's pool.

At the moment, he runs the filtration for 5 minutes every hour from 8pm to 8am (night) and 5 minutes every 3 hours the rest of the time.

What would be nice would be to integrate a risk of frost mode (weather forecast) to increase the rate.

Under Jeedom there was a pscine plugin which seemed to be well done, but I never tested it. Maybe an inspiration if you want to achieve something complete.

Yes I wrote a lot of things, Jeedom is far away...

@oncleben31
Copy link
Owner

Hello guys. Thank you for your contribution to my integration. To be honest I didn't invest the required energy to make it more mature.
I like your proposals. So let's try to improve it.

I will review it quickly

dadge added 3 commits May 11, 2021 12:35
fix update to 2021.5
Add an additional run of 1h at sunset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants