Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move password to .env file for better security and easier management #47

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

arshxb
Copy link
Contributor

@arshxb arshxb commented Feb 1, 2025

Replacing the hardcoded password with an environment variable (PAGE_ACCESS_PASSWORD).

Changes:

  1. Updated .env.example to include PAGE_ACCESS_PASSWORD.
  2. Modified authenticate.ts to use process.env.PAGE_ACCESS_PASSWORD instead of a hardcoded value. Added error message if password is not set in env file.
  3. Updated the comment in config.js to point the user to the env file (instead of authenticate.ts)

May need to update the README to include instructions on setting up the .env file, or leave it out since a missing password only triggers a server error prompting to set it first. It doesn’t affect the frontend user experience, that simply keeps displaying "Wrong password.

Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magic-portfolio-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2025 7:52pm

Copy link

vercel bot commented Feb 12, 2025

@lorant-one is attempting to deploy a commit to the Dopler Team on Vercel.

A member of the Team first needs to authorize it.

@lorant-one lorant-one merged commit 1ce4d76 into once-ui-system:main Feb 12, 2025
1 check failed
@lorant-one
Copy link
Member

thanks for your contribution @arshxb, you've been automatically added to our Hall of Fame ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants