-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement PUT for inventory UPF #278
Merged
ghislainbourgeois
merged 17 commits into
omec-project:main
from
patriciareinoso:TELCO-1549-edit-upf
Jan 28, 2025
Merged
feat: implement PUT for inventory UPF #278
ghislainbourgeois
merged 17 commits into
omec-project:main
from
patriciareinoso:TELCO-1549-edit-upf
Jan 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriciareinoso
force-pushed
the
TELCO-1549-edit-upf
branch
from
January 20, 2025 15:09
59f3057
to
a5ee2c2
Compare
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
patriciareinoso
force-pushed
the
TELCO-1549-edit-upf
branch
from
January 21, 2025 09:50
a5ee2c2
to
aed93e2
Compare
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
patriciareinoso
commented
Jan 21, 2025
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
patriciareinoso
commented
Jan 22, 2025
patriciareinoso
commented
Jan 24, 2025
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
patriciareinoso
commented
Jan 27, 2025
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
gatici
reviewed
Jan 28, 2025
Looks good. A minor comments are added. |
Signed-off-by: Patricia Reinoso <patricia.reinoso@canonical.com>
gatici
approved these changes
Jan 28, 2025
ghislainbourgeois
approved these changes
Jan 28, 2025
ghislainbourgeois
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the edition of UPFs
Given that we can create a NS containing a UPF before or after the creation of a UPF object, the PUT and the POST UPF operations are propagated to the NS containing it.
Edition of UPF is propagated to Network slices containing a UPF with the given name using a PATCH operation to modify only the UPF field.
We use transactions to ensure that both DB updates are successfully executed or reverted.
The POST and PUT handlers do not use the config channel -> reduce complexity.