Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "windows" and "color" from omero metadata as required #202

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

giovp
Copy link
Contributor

@giovp giovp commented Jul 6, 2023

ref #192 . I left the "windows" parameters as "required" but I'm not sure if it makes sense.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

Automated Review URLs

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec change looks good to me.
I don't see that this relaxation needs any changes to the tests

@will-moore
Copy link
Member

I think the failing test above is due to the trailing comma on the previous line that needs to be removed

@giovp
Copy link
Contributor Author

giovp commented Aug 4, 2023

bump

@will-moore will-moore merged commit 3ab738b into ome:main Aug 7, 2023
@will-moore
Copy link
Member

Thanks!

github-actions bot added a commit that referenced this pull request Aug 7, 2023
remove "windows" and "color" from omero metadata as required

SHA: 3ab738b
Reason: push, by @will-moore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@joshmoore joshmoore added this to the 0.5 milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants