-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve description of omero metadata #191
Conversation
Automated Review URLs |
Thanks, @giovp! (https://ngff--191.org.readthedocs.build/latest/index.html#omero-md) If no one else has any comments, I'll move to get this in. |
Looks good. Although we normally wouldn't make changes to a spec after release, this extra info could be added back to the But not a blocker! |
Also with #192 proposed, this change in latest would be updated again before release, so it would be good to have this description in the v0.4 spec, where it won't change. |
sorry for radio silence @will-moore @joshmoore , I have time now, shall I just add the info as optional as discussed in #192 ? I yes, I can then submit changes to IO in |
I would copy what you have now to the v0.4 spec - since it describes that spec and is worth having there. Then (probably in #192) update it in the in |
done, added it to 0.4 |
Great, thanks! |
improve description of omero metadata SHA: 99b8765 Reason: push, by @will-moore Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Currently, the omero metadata section in the specs could be a bit more descriptive, this is a small attempt.
This info was kindly summarized by @will-moore here: ome/ome-zarr-py#261 (comment)
EDIT: while this PR is purely to improve documentation, might be related to potential relaxation of omero metadata as discussed in #192