-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dark mode for Bootstrap 5 #4548
base: master
Are you sure you want to change the base?
fix dark mode for Bootstrap 5 #4548
Conversation
updated bootstrap scss files to support the use of table-dark.
Initially I happily though this will solve my problem and I urged to merge this. However this does not switch between dark/light modes EDIT: Add to scss file overrides for dark mode, referenced variables come from bootstrap [data-bs-theme="dark"] {
.tabulator {
background-color: $body-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
.tabulator-row {
background-color: $body-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
&:hover {
background-color: $body-tertiary-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
}
}
&:not(.thead-light) .tabulator-header {
background-color: $body-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
.tabulator-col {
background-color: $body-bg-dark;
&:hover {
background-color: $body-tertiary-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
}
.tabulator-header-filter {
input {
background-color: $body-bg-dark;
border: 1px solid $border-color-dark;
color: $body-color-dark;
&:focus {
color: $body-color-dark;
background-color: $body-bg-dark;
border: 1px solid $primary;
}
}
}
}
}
.tabulator-footer {
background-color: $body-tertiary-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
}
.tabulator-cell {
background-color: $body-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
&:hover {
background-color: $body-tertiary-bg-dark;
color: $body-color-dark;
border-color: $border-color-dark;
}
}
}
} This is a crude example and something might still be light, but the idea. |
Looking to see when this will be merged into a release |
edited scss so that dark theme now works with bootstrap 5's "color modes"
@liepumartins, thanks for pointing that out, I've now amended it so that it will also work with Bootstrap 5's color modes e.g. the data-bs-theme attribute |
Minimal reproducible example: data-bs-theme="light" ![]() data-bs-theme="dark" ![]() |
This issue has been raised before on here and on SO:
#4380
https://stackoverflow.com/questions/77524543/tabulator-js-5-apply-bootstrap-js-5-dark-theme
However, the issue still seems to persist when applying table-dark to bootstrap tables.
Currently, this is what a table looks like with the "table-dark" class:
https://jsfiddle.net/Lz8eacs7/
With the changes to the .scss files, when the compiled .css file is used it looks like this:
https://jsfiddle.net/tyvawr40