Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTree rendering can result in maximum call stack size exceeded #4599

Open
s-cork opened this issue Oct 15, 2024 · 1 comment
Open

DataTree rendering can result in maximum call stack size exceeded #4599

s-cork opened this issue Oct 15, 2024 · 1 comment
Labels
Possible Bug A possible bug that needs investigation

Comments

@s-cork
Copy link

s-cork commented Oct 15, 2024

Describe the bug
Enough TreeData when expanded can cause Uncaught RangeError: Maximum call stack size exceeded

Tabulator Info

  • Which version of Tabulator are you using?
    6.3.0

Working Example

To Reproduce
A step by step guide to recreate the issue in your JS Fiddle or Codepen:

  1. Go to https://jsfiddle.net/sc549/fdzbvngm/
  2. Expand row 1 followed by row 2 (possibly followed by row 3)
  3. Observe the page freezes
  4. Eventually the error will show in dev tools
VirtualDomVertical.js:92 Uncaught RangeError: Maximum call stack size exceeded
    at VirtualDomVertical.js:92:17
    at Array.forEach (<anonymous>)
    at b.rerenderRows (VirtualDomVertical.js:92:8)
    at f.reRenderInPosition (RowManager.js:854:18)
    at f.redraw (RowManager.js:1116:9)
    at ResizeTableModule.tableResized (ResizeTable.js:138:25)
    at InternalEventBus.js:119:25
    at Array.forEach (<anonymous>)
    at R._dispatch (InternalEventBus.js:118:21)
    at f.dispatch (CoreFeature.js:78:30)

Desktop (please complete the following information):

  • OS: Mac
  • Browser: Chrome
  • Version: 129

Additional context
It doesn't seem to be a problem in 5.x

@s-cork s-cork added the Possible Bug A possible bug that needs investigation label Oct 15, 2024
@s-cork s-cork changed the title DataTree rendering bug causes maximum call stack size DataTree rendering can result in maximum call stack size exceeded Oct 15, 2024
@schwarmco
Copy link

i just tried the fiddle with the patched version of #4598 and it seems to be fixed by that, so the expanding/collapsing triggers the same recursive rendering behavior as in #4467

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Possible Bug A possible bug that needs investigation
Projects
None yet
Development

No branches or pull requests

4 participants
@schwarmco @s-cork and others