feat(themes): adding new nekonight variant the nekonight moon and adding pull request template/issue template

[BrunoCiccarino]

adding new nekonight variant the nekonight moon, Based on the cupcake, another new variant came along, the last one of the night.

[BrunoCiccarino]

adding new nekonight variant the nekonight moon, Based on the cupcake, another new variant came along, the last one of the night.

Now I'm going to sleep because it's 1:43 am here in Brazil, tomorrow we'll see

[BrunoCiccarino]

I am back

[akinomyoga]

Could you follow the first paragraph of the "New Theme" section of CONTRIBUTING.md? The contents of the theme file are almost identical with nekonight, and only the icon seems different. In this case, one can simply overwrite the icon_* variables. The branch icon in the function _omb_theme_nekonight_git_prompt_info is also different, but in this case, please modify the nekonight theme to offer a variable for the branch icon.

[BrunoCiccarino]

Could you follow the first paragraph of the "New Theme" section of CONTRIBUTING.md? The contents of the theme file are almost identical with nekonight, and only the icon seems different. In this case, one can simply overwrite the icon_* variables. The branch icon in the function _omb_theme_nekonight_git_prompt_info is also different, but in this case, please modify the nekonight theme to offer a variable for the branch icon.

Did you mean putting everything in the same file and overwriting the icon, like I would put a conditional and then depending on one icon and depending on another? it would be more interesting

[akinomyoga]

Did you mean putting everything in the same file and overwriting the icon, like I would put a conditional and then depending on one icon and depending on another? it would be more interesting

No. Please source themes/nekonight/nekonight.theme.sh from themes/nekonight-moon/nekonight-moon.theme.sh. Then you can simply overwrite a few icon_* variables.

[BrunoCiccarino]

Did you mean putting everything in the same file and overwriting the icon, like I would put a conditional and then depending on one icon and depending on another? it would be more interesting

No. Please source themes/nekonight/nekonight.theme.sh from themes/nekonight-moon/nekonight-moon.theme.sh. Then you can simply overwrite a few icon_* variables.

aaa, ok, I'll do that, I'll update here, I'm writing the documentation, even if you want help with the doc website, I'm studying web development and it would be cool to learn

[BrunoCiccarino]

I'm experiencing some errors, and it may take a while for me to fix, but I'll update the progress here.

[BrunoCiccarino]

I managed to tidy it up and modularize it, so I can reuse the base in more themes

[BrunoCiccarino]

I think now it will be easier to do the others I'm planning

[BrunoCiccarino]

You're right, it really does get better...

[BrunoCiccarino]

What do you think about making a group on discord?

[akinomyoga]

I don't use Discord, so I don't check messages in Discord regularly. Even if someone would write messages, I respond after several days, which I think is not useful. On the other hand, I'm mostly on GitHub all the time.

[BrunoCiccarino]

I don't use Discord, so I don't check messages in Discord regularly. Even if someone would write messages, I respond after several days, which I think is not useful. On the other hand, I'm mostly on GitHub all the time.

so it would be a good idea to open a discussion here on github, it might be good for contributors to discuss their ideas

[BrunoCiccarino]

I don't use Discord, so I don't check messages in Discord regularly. Even if someone would write messages, I respond after several days, which I think is not useful. On the other hand, I'm mostly on GitHub all the time.

so it would be a good idea to open a discussion here on github, it might be good for contributors to discuss their ideas

I only noticed now that it's already open

[akinomyoga]

so it would be a good idea to open a discussion here on github,

Yes.

it might be good for contributors to discuss their ideas

Yes. You can open a discussion at https://github.com/ohmybash/oh-my-bash/discussions.

GitHub Discussion is also useful because the discussions there will automatically be indexed by search engines (such as Google) so that users can find a discussion while searching the web globally.

P.S.

Discord discussions are usually unreachable with search engines.

Discourse (used in the Rust community) is web-based, so I noticed that it allows indexing to some extent, but the search engines don't seem to crawl Discourse discussions properly. They can crawl a discussion only when there is an external link on the web to that specific discussion.

I only noticed now that it's already open

Ah, yes.

[BrunoCiccarino]

see if this is better

[akinomyoga]

It now looks good. Please check the following point.

[akinomyoga]

I'll check it later again and will merge. Thanks!

[BrunoCiccarino]

I'll check it later again and will merge. Thanks!

I thank you

[akinomyoga]

Thanks!