Correction in the powerline-icon theme #514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Theme based on powerline with icon usage | powerline-icon
Fixed Bugs: - An error in one of the powerline functions has been corrected, which was preventing the display of the icon for a successfully executed command.
akinomyoga
requested changes
Jan 9, 2024
There was a problem hiding this comment.
Can you first squash all those commits? Actually, this should have been done before submitting the PR. After that I'll leave a comment.
Also, please read the relevant section in CONTRIBUTING.
- In particular, please do not make a PR with the same branch as the main one in the upstream, i.e.,
master. This causes conflicts when the maintainer needs to take a look at the PR branch in local hosts. It requires the maintainers to do extra work locally. When you create a PR next time, please try to give a (hopefully) unique name to a branch so that it wouldn't conflict with other branches (including the ones of the PRs the other people submit). - Also, I forgot to check in the previous PR, but please update
themes/THEMES.md - Finally, please also update the wiki page.
|
thank you for the clarification. I'll resolve the issue in a moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an error in the powerline-icon theme; apparently, it was not displaying the icon when a command was executed successfully and returned a status of 0.