Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New theme for oh-my-bash #509

Merged
merged 8 commits into from
Jan 8, 2024
Merged

New theme for oh-my-bash #509

merged 8 commits into from
Jan 8, 2024

Conversation

TheWatcherMultiversal
Copy link
Contributor

  • Theme based on powerline with icon usage | powerline-icon

- Theme based on powerline with icon usage | powerline-icon
Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

First of all, the powerline-based themes should basically inherit the functions defined in themes/powerline/powerline.base.sh by sourcing it. Only the functions that would be modified by the powerline-icon theme should be defined in powerline-icon.base.sh. Please see powerline-*.base.sh of the other powerline-based themes:

themes/powerline-icon/powerline-icon.base.sh Outdated Show resolved Hide resolved
@TheWatcherMultiversal
Copy link
Contributor Author

Hello akinomyoga, thank you very much for reviewing my code. I hope the code correction is now correct. I will be attentive to any changes.

@akinomyoga
Copy link
Contributor

Thank you for updating! Looks good now! I'll later look at it in detail.

akinomyoga
akinomyoga previously approved these changes Jan 7, 2024
@akinomyoga
Copy link
Contributor

I applied changes that were introduced to powerline themes in #510.

Copy link
Contributor

@akinomyoga akinomyoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked it again. I have a comment on one line. Could you check it?

themes/powerline-icon/powerline-icon.base.sh Outdated Show resolved Hide resolved
@TheWatcherMultiversal
Copy link
Contributor Author

Done, the changes have been made. I remain attentive to any further modifications. Have a good day!

@akinomyoga
Copy link
Contributor

Thank you for the update! I'll merge it soon.

@akinomyoga akinomyoga merged commit 58756f9 into ohmybash:master Jan 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants