-
-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New theme for oh-my-bash #509
Conversation
TheWatcherMultiversal
commented
Dec 21, 2023
- Theme based on powerline with icon usage | powerline-icon
- Theme based on powerline with icon usage | powerline-icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
First of all, the powerline-based themes should basically inherit the functions defined in themes/powerline/powerline.base.sh
by sourcing it. Only the functions that would be modified by the powerline-icon
theme should be defined in powerline-icon.base.sh
. Please see powerline-*.base.sh
of the other powerline-based themes:
Hello akinomyoga, thank you very much for reviewing my code. I hope the code correction is now correct. I will be attentive to any changes. |
Thank you for updating! Looks good now! I'll later look at it in detail. |
I applied changes that were introduced to powerline themes in #510. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked it again. I have a comment on one line. Could you check it?
Done, the changes have been made. I remain attentive to any further modifications. Have a good day! |
Thank you for the update! I'll merge it soon. |