lib/history: remove redundant export for HISTIGNORE #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There does not seem to be no specific reason that we export HISTIGNORE [1]. These lines were introduced in commit 53fb803 but only HISTIGNORE had `export'. [1] ohmybash#500 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There does not seem to be a specific reason that we export HISTIGNORE as mentioned in #500 (comment). These lines were introduced in commit 53fb803 but only HISTIGNORE had
export.In this PR, I try to remove the redundant
exportfrom the definition ofHISTIGNORE. I'll wait for a while. If anyone has a reason to export HISTIGNORE, please let me know in this PR.