-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added Twitter to connect #490
Conversation
@Indrajeety993648 is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
@rithviknishad please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you discard all changes that are unrelated to the issue?
Feel free to create separate issues for each of the extra things solved.
@rithviknishad One prettier related problem that is necessary to solve during commit that I changed . Rest are related to Issue , Please review and merge this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@rithviknishad please review . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you discard changes to the lockfile?
NEXT_PUBLIC_GITHUB_URL: process.env.NEXT_PUBLIC_GITHUB_URL, | ||
NEXT_PUBLIC_LINKEDIN_URL: process.env.NEXT_PUBLIC_LINKEDIN_URL, | ||
NEXT_PUBLIC_YOUTUBE_URL: process.env.NEXT_PUBLIC_YOUTUBE_URL, | ||
NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, // Add this line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, // Add this line | |
NEXT_PUBLIC_TWITTER_URL: process.env.NEXT_PUBLIC_TWITTER_URL, |
@@ -17,6 +17,7 @@ export const env = createEnv({ | |||
NEXT_PUBLIC_GITHUB_URL: z.string(), | |||
NEXT_PUBLIC_LINKEDIN_URL: z.string(), | |||
NEXT_PUBLIC_YOUTUBE_URL: z.string(), | |||
NEXT_PUBLIC_TWITTER_URL: z.string().optional(), // Add this line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NEXT_PUBLIC_TWITTER_URL: z.string().optional(), // Add this line | |
NEXT_PUBLIC_TWITTER_URL: z.string().optional(), |
{env.NEXT_PUBLIC_TWITTER_URL && ( | ||
<SocialLink | ||
href={env.NEXT_PUBLIC_TWITTER_URL} | ||
icon={FaTwitter} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be using the Twitter's X logo instead
Add Twitter Support to Footer
Issue Fixes : #480
Description
This pull request introduces support for displaying a Twitter link in the footer component of the application. The following changes have been made:
Updated
Footer.tsx
Component:Connect
section.NEXT_PUBLIC_TWITTER_URL
in the environment variables.Updated Environment Configuration (
env.mjs
):NEXT_PUBLIC_TWITTER_URL
to handle the optional Twitter URL.Fixed Formatting and Style Issues:
Changes
Footer.tsx
Connect
section.env.mjs
NEXT_PUBLIC_TWITTER_URL
in the environment configuration.Checklist
Testing Instructions
.env
file includes theNEXT_PUBLIC_TWITTER_URL
variable.