-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DevOps Docs #57
base: master
Are you sure you want to change the base?
Add DevOps Docs #57
Conversation
✅ Deploy Preview for docs-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@gigincg can you review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have just looked into the digital ocean docs and its incomplete.
This is a partial review of just the DO file.
6a44816
to
c13acc5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets name the files right.
We shoudn't have files with names like 1.md
, 2.md
, x.md
etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an Infrastructure overview. Use mermaid diagram for building diagrams.
Example: https://deploydocs.coronasafe.network/cloud-deployment-overview/diagram
yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets either use npm or yarn. Mixing both will be a pain.
@@ -70,6 +70,7 @@ const config: Config = { | |||
{ to: "/docs/care", label: "Care", position: "left" }, | |||
{ to: "/docs/ayushma/", label: "Ayushma", position: "left" }, | |||
{ to: "/docs/leaderboard/", label: "Leaderboard", position: "left" }, | |||
{ to: "/docs/devops/", label: "DevOps", position: "left" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move it up to line 71
@@ -0,0 +1,14 @@ | |||
# DevOps Docs Overview | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an introduction.
@dauntlessnomad @gigincg Please review the PR |
@tellmeY18 whats the status here!!!!! |
Finishing up the last bit of changes. Will commit the changes tonight. |
solves #48