Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DevOps Docs #57

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add DevOps Docs #57

wants to merge 5 commits into from

Conversation

tellmeY18
Copy link

solves #48

Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for docs-ohc ready!

Name Link
🔨 Latest commit 3eeb87c
🔍 Latest deploy log https://app.netlify.com/sites/docs-ohc/deploys/67074a06b8747a00090bfcab
😎 Deploy Preview https://deploy-preview-57--docs-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bodhish
Copy link
Member

bodhish commented Sep 30, 2024

@gigincg can you review this.
I am not sure why we need docs for the CI files. A few of it looks redundant.

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just looked into the digital ocean docs and its incomplete.
This is a partial review of just the DO file.

docs/devops/Deploy/Care/digitalOcean/index.md Show resolved Hide resolved
docs/devops/Deploy/Care/digitalOcean/index.md Show resolved Hide resolved
docs/devops/Deploy/Care/digitalOcean/index.md Outdated Show resolved Hide resolved
docs/devops/Deploy/Care/digitalOcean/index.md Outdated Show resolved Hide resolved
docs/devops/Deploy/Care/digitalOcean/index.md Outdated Show resolved Hide resolved
docs/devops/Deploy/Care/digitalOcean/index.md Outdated Show resolved Hide resolved
docs/devops/Deploy/Care/digitalOcean/index.md Outdated Show resolved Hide resolved
@tellmeY18 tellmeY18 force-pushed the master branch 2 times, most recently from 6a44816 to c13acc5 Compare October 6, 2024 19:29
del

ts

added index

del

add
Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets name the files right.
We shoudn't have files with names like 1.md, 2.md, x.md etc.

Copy link
Member

@bodhish bodhish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an Infrastructure overview. Use mermaid diagram for building diagrams.
Example: https://deploydocs.coronasafe.network/cloud-deployment-overview/diagram

yarn.lock Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets either use npm or yarn. Mixing both will be a pain.

@@ -70,6 +70,7 @@ const config: Config = {
{ to: "/docs/care", label: "Care", position: "left" },
{ to: "/docs/ayushma/", label: "Ayushma", position: "left" },
{ to: "/docs/leaderboard/", label: "Leaderboard", position: "left" },
{ to: "/docs/devops/", label: "DevOps", position: "left" },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it up to line 71

@@ -0,0 +1,14 @@
# DevOps Docs Overview

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an introduction.

@bodhish
Copy link
Member

bodhish commented Oct 7, 2024

@dauntlessnomad @gigincg Please review the PR

@bodhish
Copy link
Member

bodhish commented Oct 18, 2024

@tellmeY18 whats the status here!!!!!

@tellmeY18
Copy link
Author

Finishing up the last bit of changes. Will commit the changes tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants