Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a better search UI for patients index page(#8691) #8818

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

i0am0arunava
Copy link

@i0am0arunava i0am0arunava commented Oct 17, 2024

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@i0am0arunava i0am0arunava requested a review from a team as a code owner October 17, 2024 17:31
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 924b79c
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671357eff36750000872af2b
😎 Deploy Preview https://deploy-preview-8818--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Oct 17, 2024
@rithviknishad rithviknishad removed the Deploy-Failed Deplyment is not showing preview label Oct 18, 2024
@Jacobjeevan
Copy link
Contributor

@i0am0arunava make sure to follow the PR format we have - proposed changes that mentions the issue # and merge checklist :)

@i0am0arunava
Copy link
Author

@i0am0arunava make sure to follow the PR format we have - proposed changes that mentions the issue # and merge checklist :)

okay I am doing

@bodhish
Copy link
Member

bodhish commented Oct 18, 2024

This is not what we want, please check the comments in #8725 (review)

@i0am0arunava
Copy link
Author

i0am0arunava commented Oct 18, 2024

This is not what we want, please check the comments in #8725 (review)

okay,I am making the changes as required.

i0am0arunava and others added 5 commits October 18, 2024 20:03
This merge brings in the latest changes from the upstream develop branch, ensuring
that my feature branch is up to date with the latest updates and fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants