-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix#8815/fix clear button aligned arrow #8817
base: develop
Are you sure you want to change the base?
Fix#8815/fix clear button aligned arrow #8817
Conversation
… fix#8815/fix-clear-button_aligned-arrow
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@rithviknishad @nihal467 the cross button is implemented such that it opens the dropdown on click , do you want to remove this? current: 17.10.2024_16.19.02_REC.online-video-cutter.com.mp4i have implemented the changes which will not open the dropdown on click of cross button, should i push? 17.10.2024_17.49.55_REC.mp4 |
@NitinPSingh the cross button is implemented such that it opens the dropdown on click , keep this behavior itself |
@nihal467 ok , i havent push that part yet , so the current code will clear the selected and also open the drop-down |
@NitinPSingh https://github.com/ohcnetwork/care_fe/actions/runs/11402328266/job/31727083859?pr=8817 , there is cypress failure, can you fix it |
all green now |
LGTM |
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
17.10.2024_16.19.02_REC.online-video-cutter.com.mp4