Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#8815/fix clear button aligned arrow #8817

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

NitinPSingh
Copy link
Contributor

Proposed Changes

@ohcnetwork/care-fe-code-reviewers

17.10.2024_16.19.02_REC.online-video-cutter.com.mp4

@NitinPSingh NitinPSingh requested a review from a team as a code owner October 17, 2024 11:03
Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 291615e
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6712696a094995000856ba21
😎 Deploy Preview https://deploy-preview-8817--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NitinPSingh
Copy link
Contributor Author

@rithviknishad @nihal467 the cross button is implemented such that it opens the dropdown on click , do you want to remove this?

current:

17.10.2024_16.19.02_REC.online-video-cutter.com.mp4

i have implemented the changes which will not open the dropdown on click of cross button, should i push?

17.10.2024_17.49.55_REC.mp4

@nihal467
Copy link
Member

@NitinPSingh the cross button is implemented such that it opens the dropdown on click , keep this behavior itself

@NitinPSingh
Copy link
Contributor Author

@nihal467 ok , i havent push that part yet , so the current code will clear the selected and also open the drop-down

@nihal467
Copy link
Member

@NitinPSingh
Copy link
Contributor Author

all green now

@nihal467
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear Button of Spoke Facility Dropdown in facility details update page is not working
3 participants