Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Misaligned text when there's no data #8807

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fixed Misaligned text when there's no data #8807

wants to merge 4 commits into from
+180 −158

Conversation

nithish1018
Copy link

Proposed Changes

This is how it looks now:

image
image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@nithish1018 nithish1018 requested a review from a team as a code owner October 16, 2024 17:09
@netlify Netlify
Copy link

netlify bot commented Oct 16, 2024 •
edited
Loading

✅ Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 38ba73b
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671242b4fa4c820008051b62
😎 Deploy Preview https://deploy-preview-8807--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bodhish
bodhish requested changes Oct 17, 2024
View reviewed changes
src/Components/Shifting/ListView.tsx Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@rithviknishad rithviknishad mentioned this pull request Oct 17, 2024
Open
6 tasks
@nihal467
Copy link
Member

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish bodhish requested changes

@rithviknishad rithviknishad rithviknishad approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misaligned Text - "No patients to show" in List View of Shifting Page
4 participants
@nithish1018 @nihal467 @bodhish @rithviknishad