-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ventilator mode/oxygen modality data on consultation page #8781
base: develop
Are you sure you want to change the base?
Ventilator mode/oxygen modality data on consultation page #8781
Conversation
- Added ventilator data as table on Ventilator tab - Added Marker Area to graphs under ventilator tab
- To do: cleanup (only keep whichever one is chosen, cleanup commented out code)
- Choosing markLine as that represents the data accurately (when switching to bar graph)
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Jacobjeevan is the PR ready for testing |
@nihal467 Yea, finalized on using the line graphs in the call yesterday. There maybe some changes with the label styling, but it's good to go for the most part. Edit: Apart from any code review updates ofc. |
👋 Hi, @Jacobjeevan, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
👋 Hi, @Jacobjeevan, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@aparnacoronasafe Do we need any additional changes here? As mentioned above, going with markLine graph as they are accurate when switching to bar graphs. Edit: Changes made as requested, ready for review 👍 |
👋 Hi, @Jacobjeevan, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Proposed Changes
Take a look at the font styling for the label, can adjust as needed; could do the same for label position as well (check the #8264 thread for examples).
@ohcnetwork/care-fe-code-reviewers
Merge Checklist