Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ventilator mode/oxygen modality data on consultation page #8781

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 14, 2024

Proposed Changes

image

Take a look at the font styling for the label, can adjust as needed; could do the same for label position as well (check the #8264 thread for examples).

image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

- Added ventilator data as table on Ventilator tab
- Added Marker Area to graphs under ventilator tab
- To do: cleanup (only keep whichever one is chosen, cleanup commented out code)
- Choosing markLine as that represents the data accurately (when switching to bar graph)
@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 14, 2024 09:41
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 6020479
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/671220f57d074f00080b7a54
😎 Deploy Preview https://deploy-preview-8781--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@Jacobjeevan is the PR ready for testing

@nihal467 nihal467 added the question Further information is requested label Oct 14, 2024
@Jacobjeevan
Copy link
Contributor Author

Jacobjeevan commented Oct 15, 2024

@Jacobjeevan is the PR ready for testing

@nihal467 Yea, finalized on using the line graphs in the call yesterday. There maybe some changes with the label styling, but it's good to go for the most part.

Edit: Apart from any code review updates ofc.

@Jacobjeevan Jacobjeevan added needs review and removed question Further information is requested labels Oct 15, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024
Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Jacobjeevan Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 16, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 16, 2024
Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Jacobjeevan
Copy link
Contributor Author

Jacobjeevan commented Oct 17, 2024

@aparnacoronasafe Do we need any additional changes here? As mentioned above, going with markLine graph as they are accurate when switching to bar graphs.

Edit: Changes made as requested, ready for review 👍

@Jacobjeevan Jacobjeevan removed the merge conflict pull requests with merge conflict label Oct 18, 2024
Copy link

👋 Hi, @Jacobjeevan,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflict pull requests with merge conflict needs review
Projects
None yet
2 participants