Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Update: disallow decimals for certain fields #8776

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 14, 2024

Proposed Changes

Backend doesn't accept decimal values for certain fields, so rounding the values to nearest integer instead.

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 14, 2024 07:32
Copy link

netlify bot commented Oct 14, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit e316a0a
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/670fbe6845c6dd0008580568
😎 Deploy Preview https://deploy-preview-8776--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@rithviknishad @Jacobjeevan once the PR is read for review, post a comment or change the label to need testing

- removed the parameter added to keep track if field should be int only
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABG Log update -PCO2 decimal number entry not allowed.
3 participants